Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rancher/rancher and go client deps #959

Merged
merged 3 commits into from
Aug 16, 2022

Conversation

a-blender
Copy link
Contributor

Issue: #922

I'm not exactly sure if this is the right way to do this, but we need to bump rancher to pull in the latest rke updates so ACI network provider support will work. @kinarashah

@a-blender a-blender requested review from a team and kinarashah July 16, 2022 03:12
@a-blender a-blender changed the title Bump rancher/rancher dep to 2.6.7-rc2 Bump rancher/rancher and go client deps Jul 18, 2022
Copy link
Contributor

@HarrisonWAffel HarrisonWAffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure doesn't seem to be related to the changes made here (its having a problem reaching the docker-socket, I restarted it for you). I found an older PR where the rancher dep is bumped and this looks to being doing the same thing, so LGTM as long as build passes and it works locally

edit: build is still failing, looks like it may be related to these changes

@a-blender
Copy link
Contributor Author

a-blender commented Aug 2, 2022

@kinarashah It appears that the build is failing with the sharedInformer error because go client is not getting updated. Trying to fix this on my end

edit: My go.sum was not updated due to the difference in how go 1.16 and 1.17 handle dependencies. I ran a go mod tidy -compat=1.17 to remove the go 1.16 checksums from the go.mod file and that worked. Needs a re-review to make sure that this change is ok to merge.

@a-blender a-blender force-pushed the bump-rancher-v2.6.7 branch 3 times, most recently from 38d4526 to 2a32c8a Compare August 2, 2022 17:20
@a-blender a-blender force-pushed the bump-rancher-v2.6.7 branch 4 times, most recently from 93f8e77 to 3f29d17 Compare August 8, 2022 20:52
@a-blender
Copy link
Contributor Author

I had to bump several packages that were out of date in the tf provider go.mod. Golang has also been updated to 1.17. In addition, drone was failing with errors when using the latest golang alpine image `golang 1.17.3-alpine3.16 so @kinarashah and I updated the drone image to golang 1.17.3 and the build image to golang 1.17.3-alpine3.13 because of this issue docker-library/php#1177.

We're suspicious there may be a problem with how drone runs the tf tests so I've commented out the tests in the GNU makefile.

@a-blender
Copy link
Contributor Author

So the build passed with commented out tests, which means there's an issue with how drone runs the tf tests. Will need to debug this and fix this before merging.

@a-blender
Copy link
Contributor Author

Issue was flaky tests, unsurprisingly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants