Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to generate v3.Cluster #298

Closed
richardcase opened this issue Dec 5, 2023 · 1 comment · Fixed by #362
Closed

Add ability to generate v3.Cluster #298

richardcase opened this issue Dec 5, 2023 · 1 comment · Fixed by #362
Assignees
Labels
area/import kind/feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@richardcase
Copy link
Contributor

Add an alternative import strategy to Rancher Turtles that will generate a management.v3.Cluster instead of a provisioning.v1.Cluster.

This is to ensure that we can support this scenario in light of future changes to Rancher.

A small amount of investigation was done: rancher/highlander#42

@richardcase richardcase self-assigned this Dec 5, 2023
@richardcase
Copy link
Contributor Author

I suggest that we add a new feature flag that when set to true will enable a slightly different import strategy.

The alternative strategy will:

  • Generate a management.cattle.io/v3/Cluster with DisplayName in the spec (and also probably Description). We'll need to use generateName for example:
apiVersion: management.cattle.io/v3
kind: Cluster
metadata:
  generateName: c-
spec:
  displayName: "child1"
  description: "some cluster created by capi"
  • If Connected status is true then we could probably exit early
  • Get the ClusterRegistrationToken from the namespace with the same name as the v3.Cluster
  • Apply the import manifests to the schild cluster (like we do now)

@richardcase richardcase removed their assignment Dec 5, 2023
@richardcase richardcase added this to the Early access - v0.5.0 milestone Dec 5, 2023
@richardcase richardcase added area/import kind/feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 5, 2023
@salasberryfin salasberryfin self-assigned this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/import kind/feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Development

Successfully merging a pull request may close this issue.

3 participants