✨ Support creating management v3 cluster #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
15 times, most recently
from
ef74d3e
to
fa01e18
Compare
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
3 times, most recently
from
9ab7beb
to
0de8141
Compare
salasberryfin
changed the title
salasberryfin
commented
Feb 2, 2024
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
4 times, most recently
from
f3988f0
to
dcacd4a
Compare
salasberryfin
requested review from
richardcase
and removed request for
a team
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
from
f74610b
to
463bf77
Compare
|
This is now updated and rebased with the recent changes to the test environment. |
|
Seems like this is now ready for a final review. Thanks everyone for taking the time to add your suggestions. |
|
Reminder that there's also this documentation PR rancher/turtles-docs#59 to document the new feature flag. |
Danil-Grigorev
previously approved these changes
Feb 28, 2024
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
2 times, most recently
from
9f4d45f
to
927cae7
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
support-creating-management-v3-cluster
branch
from
927cae7
to
6c02634
Compare
Danil-Grigorev
approved these changes
Mar 4, 2024
richardcase
approved these changes
Mar 4, 2024
alexander-demicev
approved these changes
Mar 5, 2024
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for representing imported CAPI clusters as
management.cattle.io/v3clusters instead of the currentprovisioning.cattle.io/v1resource.ADR 8 contains the rationale behind choosing this implementation approach and the discussions on different alternatives before agreeing to a decision.
This includes a new import controller specific for the new type of resource, which is only enabled if using a feature flag, so the default behavior of Rancher Turtles is to continue with the current import strategy. Some of the functions that are used by both controllers have been centralized so that we have less code to maintain. Still, some of the controller code is very similar to one another but re-utilizing it would probably increase complexity and reduce readability.
An E2E specification equivalent to the existing
import gitopshas been created for when Rancher Turtles is executed with this feature flag enabled.There are definitely improvements to the way the code is structured. Especially in terms of increasing the re-usability, for both controller and E2E, but my opinion is that this PR is large enough to also add a larger refactor. Probably it would be better if we can have a couple of follow-ups to simplify the code where possible. But this is obviously a team decision. Additionally, there will be a discussion on whether we should move completely to this new controller and deprecate
provisioning.cattle.io, so it may not make much sense to invest time in increasing re-usable components at this point.Which issue(s) this PR fixes:
Fixes #298
Special notes for your reviewer:
The DeletionTimestamp seems to not be set when the Rancher Cluster is deleted. The logic is the same that we use for other controller, though. I would appreciate any feedback on this. I'll leave a comment below.The new feature flag is added to the docs here.
Checklist: