Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable kubeadm provider installation by default #402

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Disable kubeadm provider by default, we will enable RKE2 provider as a default one in a follow-up PR

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 29, 2024
@alexander-demicev alexander-demicev requested a review from a team as a code owner February 29, 2024 10:19
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the e2e tests as a result of this. Maybe the e2e should install the kubeadm providers to start with.

@alexander-demicev
Copy link
Member Author

alexander-demicev commented Mar 13, 2024

@richardcase I included kubeadm provider installation in e2e tests

@alexander-demicev alexander-demicev merged commit e07a175 into rancher:main Mar 13, 2024
13 checks passed
@alexander-demicev alexander-demicev deleted the disablekubeadm branch March 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants