Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove older versions of elemental #30

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Nov 3, 2023

remove older versions of elemental

@jordojordo , will this sync automatically? meaning, will it remove these versions and generate the chart again?

@jordojordo
Copy link
Member

@aalves08 This will not remove the versions that have already been synced. But I'm curious why you would want to remove the older versions?

@aalves08
Copy link
Contributor Author

aalves08 commented Nov 13, 2023

It was a request from the backend developer I've talked with. Apparently it creates more havoc because they have to support multiple versions of the images for the OS iso build. They used to be stored in other places and now everything should be centralised with what's in version 1.2.0.

FYI @nwmac

@jordojordo
Copy link
Member

jordojordo commented Nov 13, 2023

Makes sense, in that case you will need to remove all of the chart assets for those versions in assets, charts, extensions, and icons - In addition the entries within for those versions will need to be removed from the index.yaml.

This will not remove the versions from the releases or the ui-plugin-catalog image unfortunately, but we can release a patch version after this is merged which will not contain those versions.

@aalves08
Copy link
Contributor Author

@jordojordo can you re-review this? I've removed all of the assets needed to do a proper cleanup.

assets/elemental/elemental-1.2.0.tgz Outdated Show resolved Hide resolved
@aalves08 aalves08 force-pushed the remove-older-versions-elemental branch from b6f8b96 to 706dda8 Compare November 15, 2023 15:33
@aalves08 aalves08 merged commit 673fe71 into rancher:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants