Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues on RKE Template diff modal #5087

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Nov 24, 2023

Addresses rancher/dashboard#5954

QA re-opened this issue asking for a few things:

  1. Contrast is not compatible w/ Dark Mode - [unable to clearly view values]
  2. Compare does NOT show two templates side-by-side, confusion around which color [red/green] represents which Template (requesting colored Template labels perhaps? or side-by-side comparison)
  3. All fields with differences should be either red or green with values being compared from the respective Templates.
  4. Currently, if null/nil, in first template, and populated in second template, compare will only show populated values in green, associated with the second template. [e.g. private_registries field from screenshot]

This PR addresses 1 and 2.

The other two are not easily addressed with the library we use - having reviewed the UX, with the changes in this PR, I believe this delivers an acceptable UX.

Key added:
Screenshot 2023-11-24 at 12 58 25

Dark mode fixed:
Screenshot 2023-11-24 at 13 26 12

@nwmac nwmac merged commit c7f4bae into rancher:master Nov 30, 2023
1 check passed
@nwmac nwmac deleted the rke-template-diff branch November 30, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants