Removing all references to PSP since they will no longer be supported #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
requested changes
Jan 19, 2024
There was a problem hiding this comment.
One minor thing, it looks like these constants can be removed. Otherwise looks good; I couldn't see any broken pages nor other references to psps
codyrancher
force-pushed
the
psp-removal
branch
from
c1396d1
to
dd1d201
Compare
Good catch. I removed that object and resolved the linting errors. |
mantis-toboggan-md
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes dead code and unnecessary messaging since PSPs will no longer be supported going forward.
Types of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Linked Issues
rancher/dashboard#9945