Update aws regions and add script to automate this #5112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rancher/dashboard#10294
This PR updates the list of hard-coded AWS regions for EC2 and EKS.
I've added a script which can be run to automatically do this.
Regions are sorted alphabetically across the 3 partitions that we use, so going forward it will be much easier to see the regions added/removed - for this change, you'll see more change as the region list is not currently in any order that is stable (i.e. not alphabetically sorted).
If we wished, we could set up a scheduled GH action to run this script and automatically create a PR is there are changes. We could do this for other data like this - this is at least an improvement ahead of dynamically fetching data (where this is possible).
Note, Ember UI is legacy, so we probably don't want to invest in dynamic lookup and should do that was we continue to port functionality over to dashboard.