Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to use private registry for helm deployment #42661

Open
seb-835 opened this issue Oct 13, 2022 · 4 comments
Open

ability to use private registry for helm deployment #42661

seb-835 opened this issue Oct 13, 2022 · 4 comments
Labels
area/webhook priority/2 team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Milestone

Comments

@seb-835
Copy link

seb-835 commented Oct 13, 2022

When using a private registry to pull image,
the webhook chart / template manifests are missing imagePullSecrets parameters to authenticate against registry.

Should be nice to add in helm templating file:

spec:
{{- if .Values.imagePullSecrets }}
      imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 6 }}
@seb-835 seb-835 changed the title ability to use private registry for helm deployment A ability to use private registry for helm deployment Oct 13, 2022
@KevinJoiner
Copy link
Contributor

We could add this ability to rancher-webhook but the setting would not be used unless we also update the rancher server to propagate the value when deploying the rancher-webhook helm chart. You can create a feature request in https://github.com/rancher/rancher project since the rancher pod is responsible for managing the deployment values of rancher-webhook.

@KevinJoiner
Copy link
Contributor

With the changes added here #41142. Users can now pass arbitrary helm values down from Rancher to the Webhook helm release. That means we can update the Webhook chart to support private registry secrets without the need to have additional rancher/rancher updates.

@samjustus samjustus transferred this issue from rancher/webhook Sep 5, 2023
@samjustus samjustus added this to the 2024-Q1-v2.8x milestone Sep 5, 2023
@samjustus
Copy link
Collaborator

moving to backlog (unscheduled)

@samjustus samjustus modified the milestones: 2024-Q1-v2.8x, v2.8.x Sep 11, 2023
@samjustus samjustus modified the milestones: v2.8.x, v2.x - Backlog Oct 31, 2023
@samjustus samjustus modified the milestones: v2.x - Backlog, Unscheduled Jan 31, 2024
@samjustus samjustus added team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas and removed team/area1 labels Feb 1, 2024
@sravanakinapally
Copy link

How can we use a private registry for rancher-webhook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhook priority/2 team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Projects
None yet
Development

No branches or pull requests

6 participants