Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Product Registry configurable #194

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

clausa
Copy link
Contributor

@clausa clausa commented Feb 26, 2024

Please check below, if the PR fulfills these requirements:

  • The commit message follows the guidelines.
    Hopefully - This is my first PR...
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

What is the current behavior?

  • Product Registry is hardcoded to rgcrprod.azurecr.us

What is the new behavior (if this is a feature change)?

  • You can specify a Product Registry with the --product-registry (or -c ?) cli flag.

Does this PR introduce a breaking change?

  • No

Other information:

bin/hauler store sync --products rke2=v1.28.5+rke2r2 --product-registry mcr.csa-net.dk:5000  
10:12PM INF processing content file for product: 'rke2=v1.28.5+rke2r2'
10:12PM INF retrieving product manifest from: 'mcr.csa-net.dk:5000/hauler/rke2-manifest.yaml:v1.28.5-rke2r2'
10:12PM INF added 'image' to store at [mcr.csa-net.dk:5000/hauler/rke2-manifest.yaml:v1.28.5-rke2r2]
10:12PM INF extracted [application/vnd.oci.image.manifest.v1+json] from store with digest [sha256:6b811e04ced86b53d5f76f8a043332325c2bb440238587266b2b27a10187a97f]
10:12PM INF extracted [application/vnd.oci.image.manifest.v1+json] from store with digest [sha256:e86ba80365854ce14a0f7e9b91b46bd105a2220901fcbb2fde08ebbe9e03444c]
10:12PM INF syncing [content.hauler.cattle.io/v1alpha1, Kind=Images] to store
10:12PM INF added 'image' to store at [mcr.csa-net.dk:5000/docker.io/rancher/hardened-calico:v3.26.3-build20231109]

@dweomer
Copy link
Contributor

dweomer commented Feb 29, 2024

Thank you @clausa for this contribution! We are amenable to this change but want to hold back a week or two to make a design pass at a roadmap to ensure this fits.

@dweomer dweomer added the enhancement New feature or request label Apr 5, 2024
@dweomer dweomer merged commit 6863d91 into rancherfederal:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants