Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated fileserver directory name #219

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Feature

Proposed Changes:

  • Updated the directory for the fileserver to be fileserver to match the registry directory of registry

Verification/Testing of Changes:

  • Add artifacts to your store, then run hauler store serve fileserver and you will see the new directory name.

Additional Context:

  • N/A

@zackbradys zackbradys self-assigned this Mar 30, 2024
@zackbradys zackbradys added enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work labels Mar 30, 2024
@dweomer
Copy link
Contributor

dweomer commented Mar 30, 2024

Would rather see this sidelined in favor of a unified hauler store serve

@zackbradys
Copy link
Member Author

zackbradys commented Apr 1, 2024

@dweomer very understandable. I wasn't sure how long it would take for the unified hauler store serve to be implemented into hauler, so this would be for the interim so the registry and fileserver would have the same look and feel and workflow.

I don't there would be any existing workflows or functionality that depends on the directory name, so thought it would be safe to update it

@dweomer dweomer merged commit 16eea6a into rancherfederal:main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants