Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Drop Node 8 support #22

Closed
wants to merge 1 commit into from
Closed

BREAKING: Drop Node 8 support #22

wants to merge 1 commit into from

Conversation

feross
Copy link
Collaborator

@feross feross commented Aug 7, 2019

Use the new fs.mkdir {recursive: true} option instead of the mkdirp dependency.

It might be too early to merge this, since Node 8 is still supported until the end of the 2019. But just sending this PR so we can merge it at some point in the future.

For: brave/brave-browser#5490

Use the new fs.mkdir {recursive: true} option instead of the mkdirp dependency.

It might be too early to merge this, since Node 8 is still supported until the end of the 2019. But just sending this PR so we can merge it at some point in the future.

For: brave/brave-browser#5490
@juliangruber
Copy link
Member

TIL about fs.mkdir(dir, { recursive: true }) :)

@mafintosh
Copy link
Collaborator

mafintosh commented Aug 7, 2019

This is a pretty critical dep for all our p2p stuff, so this (prob) won't get merged until 8 is EOL + 1 or 2.

Future notice, requires a major bump as well

@feross
Copy link
Collaborator Author

feross commented Aug 7, 2019

this (prob) won't get merged until 8 is EOL + 1 or 2

@mafintosh Sounds good.

@jimmywarting
Copy link

Time to merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants