Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking failure when using vendored feature #23

Closed
est31 opened this issue Sep 27, 2020 · 2 comments
Closed

Linking failure when using vendored feature #23

est31 opened this issue Sep 27, 2020 · 2 comments

Comments

@est31
Copy link
Contributor

est31 commented Sep 27, 2020

There seems to be a linking failure on travis when I test the new botan feature to vendor sources.

Link to a failed build: https://travis-ci.com/github/est31/rcgen/jobs/391529962

Excerpt from the logs:

error: linking with `cc` failed: exit code: 1
[...]
note: /usr/bin/ld: /home/travis/build/est31/rcgen/target/debug/deps/libbotan_sys-59cd180e5db8bbbc.rlib(ffi.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC

          /home/travis/build/est31/rcgen/target/debug/deps/libbotan_sys-59cd180e5db8bbbc.rlib: error adding symbols: Bad value

          collect2: error: ld returned 1 exit status

It works locally on my machine.

@randombit
Copy link
Owner

Interesting. Botan always compiles with PIC even for a static library only target, to support linking the library into an .so or a PIE executable. So I'm not sure how this could happen.

@randombit randombit changed the title Linking failure Linking failure when using vendored feature Sep 28, 2020
@est31
Copy link
Contributor Author

est31 commented Oct 18, 2020

Using newer ubuntu versions (18.04 instead of 16.04) fixed the issue for me: rustls/rcgen@edf1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants