Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable static library build #1324

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Conversation

randombit
Copy link
Owner

Fixes #1230 #1237 #1300

With the inclusion of a simple conditional statement in the template language it's become clear it's possible to eliminate the nmake vs Unix make distinction. I'll do that in a later PR.

Apparently introduced in #584 but unnecessary afaict as the CLI
was renamed at the same time.
@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #1324 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   91.87%   92.29%   +0.41%     
==========================================
  Files         466      466              
  Lines       43109    43109              
  Branches     5235     5235              
==========================================
+ Hits        39607    39787     +180     
+ Misses       3470     3290     -180     
  Partials       32       32
Impacted Files Coverage Δ
src/tests/test_cryptobox.cpp 77.27% <0%> (-9.1%) ⬇️
src/lib/tls/tls_session_key.cpp 92.1% <0%> (-7.9%) ⬇️
src/lib/tls/tls_client.cpp 84.25% <0%> (ø) ⬆️
src/lib/tls/tls_extensions.cpp 92.4% <0%> (+0.31%) ⬆️
src/lib/tls/tls_channel.cpp 79.45% <0%> (+0.34%) ⬆️
src/tests/unit_tls.cpp 91.38% <0%> (+0.42%) ⬆️
src/lib/tls/tls_handshake_state.cpp 83.63% <0%> (+0.45%) ⬆️
src/lib/tls/tls_server.cpp 84.06% <0%> (+0.62%) ⬆️
src/lib/prov/openssl/openssl_ec.cpp 91.85% <0%> (+0.74%) ⬆️
src/lib/block/threefish/threefish.cpp 91.83% <0%> (+1.02%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b7b4d...4e2ad46. Read the comment docs.

@randombit randombit merged commit 4e2ad46 into master Dec 1, 2017
@randombit randombit deleted the disable-static branch December 1, 2017 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants