Build fixes #1328
Merged
Build fixes #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2017
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
=========================================
- Coverage 92.28% 91.9% -0.39%
=========================================
Files 466 466
Lines 43109 43109
Branches 5235 5235
=========================================
- Hits 39785 39618 -167
- Misses 3292 3459 +167
Partials 32 32
Continue to review full report at Codecov.
|
randombit
force-pushed
the
build-fixes
branch
from
0aab321
to
e760329
Compare
It's been dropped from GCC, appears OpenACC is the new hotness for this kind of thing.
Add a test in CI to cover this
Also remove a duplicated block (rebase error)
randombit
force-pushed
the
build-fixes
branch
from
e760329
to
1891809
Compare
alonbl
reviewed
Dec 2, 2017
| clean: | ||
| $(PYTHON_EXE) $(SCRIPTS_DIR)/cleanup.py --build-dir="%{build_dir}" | ||
|
|
||
| distclean: | ||
| $(PYTHON_EXE) $(SCRIPTS_DIR)/cleanup.py --build-dir="%{build_dir}" --distclean | ||
|
|
||
| install: $(CLI) docs | ||
| install: libs cli docs |
There was a problem hiding this comment.
I suggest to:
install: all
as you always end up require all
| @@ -40,18 +41,18 @@ libs: $(LIBRARIES) | |||
|
|
|||
| # Misc targets | |||
|
|
|||
| docs: | |||
| %{build_doc_commands} | |||
There was a problem hiding this comment.
I suggest to have docs.stamp or any other file created, so that at make install the sphinx will not run again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes install target when static lib disabled (#1327)
Accept CXXFLAGS and LDFLAGS from environment, and adds docs to the
alltarget (#1237)Plus some cleanups in generating the template variables.