Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the OpenSSL provider #2827

Merged
merged 1 commit into from Dec 11, 2021
Merged

Remove the OpenSSL provider #2827

merged 1 commit into from Dec 11, 2021

Conversation

randombit
Copy link
Owner

Starting in OpenSSL 3.0, most of the functionality which we need to implement the OpenSSL provider is deprecated. Rather than reimplement the whole provider in order to allow it to continue to work in the future, just remove it. Efforts would be better spent doing more optimization work rather than chasing OpenSSL's API changes.

@codecov-commenter
Copy link

Codecov Report

Merging #2827 (dc82c81) into master (088094b) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   92.32%   92.37%   +0.04%     
==========================================
  Files         568      562       -6     
  Lines       63088    62403     -685     
  Branches     6170     6024     -146     
==========================================
- Hits        58248    57646     -602     
+ Misses       4808     4725      -83     
  Partials       32       32              
Impacted Files Coverage Δ
src/lib/ffi/ffi.cpp 74.50% <0.00%> (ø)
src/lib/kdf/kdf.cpp 92.30% <0.00%> (ø)
src/lib/pbkdf/pbkdf.cpp 56.41% <0.00%> (ø)
src/lib/pbkdf/pwdhash.cpp 67.56% <0.00%> (ø)
src/lib/pubkey/ecdh/ecdh.cpp 94.73% <ø> (-1.27%) ⬇️
src/lib/pubkey/ecdsa/ecdsa.cpp 90.62% <ø> (-1.05%) ⬇️
src/lib/pubkey/pk_algs.cpp 94.85% <ø> (-0.22%) ⬇️
src/lib/pubkey/rsa/rsa.cpp 97.00% <ø> (+0.12%) ⬆️
src/lib/utils/exceptn.cpp 45.23% <0.00%> (ø)
src/lib/block/block_cipher.cpp 98.52% <100.00%> (-0.11%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088094b...dc82c81. Read the comment docs.

src/lib/utils/exceptn.h Outdated Show resolved Hide resolved
src/tests/main.cpp Outdated Show resolved Hide resolved
Starting in OpenSSL 3.0, most of the functionality which we need to
implement the OpenSSL provider is deprecated. Rather than reimplement
the whole provider in order to allow it to continue to work in the
future, just remove it. Efforts would be better spent doing more
optimization work rather than chasing OpenSSL's API changes.
@randombit randombit mentioned this pull request Nov 1, 2021
@randombit randombit merged commit 2eed303 into master Dec 11, 2021
@randombit randombit deleted the jack/remove-openssl-prov branch December 11, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants