Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFDHE selection in TLS to conform to RFC 7919 #3743

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

randombit
Copy link
Owner

This logic was broken by the change in #3729

Closes #3742

@randombit randombit requested a review from reneme October 9, 2023 13:05
This logic was broken by the change in #3729

Closes #3742
@randombit randombit force-pushed the jack/fix-ffdhe-choice branch 2 times, most recently from 57d66a2 to a0b1eea Compare October 9, 2023 13:08
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the added details in the comments around that.

@coveralls
Copy link

Coverage Status

coverage: 91.701% (+0.004%) from 91.697% when pulling a0b1eea on jack/fix-ffdhe-choice into 6f466a2 on master.

@randombit randombit merged commit e27bf3f into master Oct 10, 2023
38 checks passed
@randombit randombit deleted the jack/fix-ffdhe-choice branch October 10, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing TLS-Anvil test caused by not recognizing DH groups
3 participants