examples target should require boost #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
approved these changes
Oct 31, 2023
|
This doesn't really seem right to me. Just a single one of the examples requires Boost; you could make a similar argument that we should require Kyber, RSA, ... since at least one of the examples will fail to compile in such a configuration. |
|
In general I agree, we should improve the examples to not be all-or-nothing. I just stumbled upon this resulting in being simply an uncompilable configuration and I at least wanted to make it explicitly fail on configure instead, as a first improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail if
examplestarget should be build, but boost is not enabled.