Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During X509 path validation, return immediately if a signature is invalid #4045

Merged
merged 1 commit into from
May 13, 2024

Conversation

randombit
Copy link
Owner

The remainder of path validation logic is still subject to attacker controlled inputs, but the range of inputs is reduced to that which a legitimate certificate authority was willing to sign.

@randombit randombit requested a review from reneme May 8, 2024 08:58
…alid

The remainder of path validation logic is still subject to attacker
controlled inputs, but the range of inputs is reduced to that which a
legitimate certificate authority was willing to sign.
@coveralls
Copy link

Coverage Status

coverage: 92.014% (-0.005%) from 92.019%
when pulling e4b4ff7 on jack/x509-path-sigs-first
into 8798305 on master.

randombit added a commit that referenced this pull request May 11, 2024
The remainder of path validation logic is still subject to attacker
controlled inputs, but the range of inputs is reduced to that which a
legitimate certificate authority was willing to sign.

Backport of #4045
randombit added a commit that referenced this pull request May 11, 2024
The remainder of path validation logic is still subject to attacker
controlled inputs, but the range of inputs is reduced to that which a
legitimate certificate authority was willing to sign.

Backport of #4045
Copy link
Collaborator

@FAlbertDev FAlbertDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree that checking the signature chain first is very sensible.

@randombit randombit merged commit 39535f1 into master May 13, 2024
43 checks passed
@randombit randombit deleted the jack/x509-path-sigs-first branch May 13, 2024 10:49
randombit added a commit that referenced this pull request May 13, 2024
[#4045 Backport] During X.509 verification, first check the signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants