Tweak XCode version detection, update CI to XCode 15.4 #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/xcode-version
branch
2 times, most recently
from
33df4ce
to
c196935
Compare
randombit
changed the title
randombit
force-pushed
the
jack/xcode-version
branch
from
c196935
to
74c594a
Compare
This gives us enough extra information that we could set the build time minimum to XCode 15.3 in the future if so desired. Using the Clang version macros did not provide a way of distinguishing XCode 15.3 from prior versions.
reneme
approved these changes
May 22, 2024
Comment on lines
+33
to
+35
| * Even __apple_build_version__ doesn't always get updated to reflect | ||
| * the XCode version, eg XCode 15.4 and XCode 15.3 both define | ||
| * __apple_build_version__ to 15000309 |
There was a problem hiding this comment.
Judging from the release notes of 15.3 and 15.4, they didn't seem to have updated clang from .3 to .4 (no clang related entries in the notes). Perhaps that's why the pre-processor define didn't get updated either.
On the plus side: That probably means, we wouldn't really benefit from being able to tell .3 and .4 apart anyway.
That said: It's still ridiculous. 🤣
There was a problem hiding this comment.
This is my guess also. XCode 15.0 through 15.2 also have the same __apple_build_version__, and there are again no Clang related changes in the release notes for 15.1 or 15.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.