Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build vanilla PKGs in SR #117

Merged
merged 1 commit into from
May 21, 2024
Merged

Build vanilla PKGs in SR #117

merged 1 commit into from
May 21, 2024

Conversation

ThanatosGit
Copy link
Contributor

This is the code which can parse and rebuild all pkg files except 11 files. The only problem is the end of the file.
Always end with 0 padding at the end of the file except for MSCU MTXT CUT which adds padding to align to 4 bytes.

  • removing MSCU from special case => more files gonna fail
  • removing MTXT from special case => more files gonna fail
  • adding MSAT to the special case => more files gonna fail

The wrong_build_sr case in the test is written in a weird way on purpose. It proofes that, of course, the length field is wrong but besides that it's only the ending which is wrong.

Don't know if it should merged 🤷‍♂️

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.19%. Comparing base (69ddf9d) to head (1019948).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   74.02%   74.19%   +0.16%     
==========================================
  Files          62       62              
  Lines        3142     3154      +12     
==========================================
+ Hits         2326     2340      +14     
+ Misses        816      814       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThanatosGit
Copy link
Contributor Author

As I have still no idea how I could ever find out the random padding at the end of the file, I would like to merge that post MSR stable.
Should I clean up anything here?

@ThanatosGit ThanatosGit marked this pull request as ready for review February 17, 2024 20:37
Copy link
Contributor

@dyceron dyceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shame about the pkgs not rebuilding properly, especially bcut, but better for now.

@henriquegemignani henriquegemignani added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 585de90 May 21, 2024
10 checks passed
@henriquegemignani henriquegemignani deleted the sr-pkg-parse branch May 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants