polycollection2d fix #130
Merged
polycollection2d fix #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steven11sjf
commented
Mar 14, 2024
steven11sjf
commented
- im stupid, turns out it's a vec3 for the AABOX's vPos's offset and it also applies to POLYCOLLECTION2D and presumably CIRCLE as well...
- im stupid, turns out it's a vec3 for the vPos's offset and it also applies to POLYCOLLECTION2D and presumably CIRCLE as well...
|
called it |
duncathan
reviewed
Mar 14, 2024
| @@ -38,14 +38,11 @@ | |||
|
|
|||
| collision_formats = { | |||
| "AABOX2D": Struct( | |||
| center=CVector2D, | |||
| unk=Float, | |||
| offset=CVector3D, | |||
There was a problem hiding this comment.
i was going for "offset from vPos", since it felt like center/position was a bit misleading. i can maybe just throw in a small comment to clarify instead.
There was a problem hiding this comment.
it's relative position, as opposed to global. in my experience relative position is the default when you just say "position"
There was a problem hiding this comment.
fair enough, fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 74.13% 74.13%
=======================================
Files 63 63
Lines 3155 3155
=======================================
Hits 2339 2339
Misses 816 816 ☔ View full report in Codecov by Sentry. |
henriquegemignani
approved these changes
Apr 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.