- Add tests for BMSLD parse and build #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThanatosGit
commented
Sep 12, 2023
ThanatosGit
commented
- Add tests for BMSLD methods
- Add tests for BMSLD methods
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 72.17% 73.13% +0.95%
==========================================
Files 56 56
Lines 3030 3030
==========================================
+ Hits 2187 2216 +29
+ Misses 843 814 -29
☔ View full report in Codecov by Sentry. |
duncathan
requested changes
Sep 12, 2023
duncathan
requested changes
Sep 12, 2023
| @@ -166,7 +166,7 @@ def get_actor_group(self, group_name: str) -> Container: | |||
| None | |||
| ) | |||
| if group is None: | |||
| raise Exception(f"No group found with name for {group_name}") | |||
| raise ValueError(f"No group found with name for {group_name}") | |||
There was a problem hiding this comment.
tbh I'd prob call this a KeyError, even if it isn't technically a dictionary. @henriquegemignani thoughts?
There was a problem hiding this comment.
Changed it to KeyError now. Both are kinda matching / non-matching. It's not a dict but very similar lookup. Otherwise you could say, you just used a wrong value for the parameter.
(just forced push as the last two changes were pretty small)
There was a problem hiding this comment.
It's a container-like enough for me.
ThanatosGit
force-pushed
the
BMSLD-Tests
branch
from
719ae4e
to
bc3b413
Compare
ThanatosGit
force-pushed
the
BMSLD-Tests
branch
from
bc3b413
to
bed95cd
Compare
duncathan
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.