Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding MP3 Pixel tracker #6777

Merged
merged 14 commits into from
Jul 9, 2024
Merged

adding MP3 Pixel tracker #6777

merged 14 commits into from
Jul 9, 2024

Conversation

Jason-Bee
Copy link
Contributor

adding a whole new layout which is more organized plus a lot of newly made pixel icons, thanks to reggie for letting me re-use some older ones and abyss for the huge help!

adding a whole new layout which is more organized plus a lot of newly made pixel icons, thanks to reggie for letting me re-use some older ones and abyss for the huge help!
@Jason-Bee
Copy link
Contributor Author

Unbenannt
here a picture of the finished product

@Miepee
Copy link
Contributor

Miepee commented Jun 24, 2024

I'll leave it up to the Corruption Maintainers to decide, but a few comments on my side (which I wouldn't be blocking the PR for)

  • I don't mean to downplay your work here, but some of the sprites really give a feeling of "took sprites and threw them together", due to how inconsistent they look. Like Morph Ball having different shading than hyper ball, which all look completely different to the spider ball, command visor sticking out like a sore thumb, or scan visor having no shading at all compared to xray.
  • The grapple upgrades look really off to me right now. Currently they give me more a feeling of "trident" than "grapple", which I assume is due to missing shading, the neck being a bit too long, and the base being invisible in non-collected mode

@Jason-Bee
Copy link
Contributor Author

" Like Morph Ball having different shading than hyper ball, which all look completely different to the spider ball,"
due to colour difference, fixed the spider issue tho to keep some consistency.

command visor sticking out like a sore thumb, or scan visor having no shading at all compared to xray.
Scan shading is adjusted, command and Xray cant be changed. xray already has a lot of shading but white on more white is hard to read, changing command would take away the readability of command compared to Combat.

The grapple upgrades look really off to me right now. Currently they give me more a feeling of "trident" than "grapple"
yea i noticed that aswell after you pointed it out, updated the handle to be more fitting, not perfect. but for sure better then before @Miepee

@Jason-Bee
Copy link
Contributor Author

image

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (40fc5ae) to head (bde888d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6777   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         674      674           
  Lines       41706    41706           
  Branches     6917     6917           
=======================================
  Hits        35477    35477           
  Misses       5076     5076           
  Partials     1153     1153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Samuel6710 Samuel6710 requested a review from Miepee June 24, 2024 14:06
@Miepee Miepee removed their request for review June 24, 2024 21:31
@ThanatosGit
Copy link
Contributor

Uh, anyone feels responsible for this?

@henriquegemignani
Copy link
Member

I kinda don't want more themes for any game before having a decent theme selector, but corruption has just one theme so far

@Miepee
Copy link
Contributor

Miepee commented Jun 26, 2024

Abyss was working on redrawing some sprites, so there will probably be more commits pushed to this

@Miepee Miepee marked this pull request as draft June 26, 2024 10:34
@Miepee
Copy link
Contributor

Miepee commented Jun 26, 2024

I'll mark this as draft until then.

@Jason-Bee Jason-Bee requested a review from Miepee June 26, 2024 18:51
@Miepee Miepee removed their request for review June 26, 2024 18:52
@Miepee
Copy link
Contributor

Miepee commented Jul 4, 2024

@Jason-Bee Bump

@Jason-Bee Jason-Bee requested a review from Miepee July 7, 2024 20:55
@Jason-Bee Jason-Bee marked this pull request as ready for review July 7, 2024 21:22
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no oneelse feels responsible, and looks fine to me, so i'll merge

@Miepee Miepee added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@Miepee Miepee added this pull request to the merge queue Jul 9, 2024
Merged via the queue into randovania:main with commit 502ae7a Jul 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants