-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding MP3 Pixel tracker #6777
adding MP3 Pixel tracker #6777
Conversation
adding a whole new layout which is more organized plus a lot of newly made pixel icons, thanks to reggie for letting me re-use some older ones and abyss for the huge help!
I'll leave it up to the Corruption Maintainers to decide, but a few comments on my side (which I wouldn't be blocking the PR for)
|
" Like Morph Ball having different shading than hyper ball, which all look completely different to the spider ball," command visor sticking out like a sore thumb, or scan visor having no shading at all compared to xray. The grapple upgrades look really off to me right now. Currently they give me more a feeling of "trident" than "grapple" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6777 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 674 674
Lines 41706 41706
Branches 6917 6917
=======================================
Hits 35477 35477
Misses 5076 5076
Partials 1153 1153 ☔ View full report in Codecov by Sentry. |
Uh, anyone feels responsible for this? |
I kinda don't want more themes for any game before having a decent theme selector, but corruption has just one theme so far |
Abyss was working on redrawing some sprites, so there will probably be more commits pushed to this |
I'll mark this as draft until then. |
randovania/data/gui_assets/tracker/pixel-icons/mp3/Command_visor.png
Outdated
Show resolved
Hide resolved
@Jason-Bee Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no oneelse feels responsible, and looks fine to me, so i'll merge
adding a whole new layout which is more organized plus a lot of newly made pixel icons, thanks to reggie for letting me re-use some older ones and abyss for the huge help!