-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional env vars #123
Merged
kmarekspartz
merged 4 commits into
randsleadershipslack:master
from
TheConnMan:additional-env-vars
Aug 31, 2017
Merged
Additional env vars #123
kmarekspartz
merged 4 commits into
randsleadershipslack:master
from
TheConnMan:additional-env-vars
Aug 31, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was the flagged disabled to avoid a bug, or do you not plan on using it? I've started to move people to the reacji-channeller instead, I hope to deprecate the flagger.
–
Kyle Marek-Spartz
… On Aug 12, 2017, at 13:24, Brian Conn ***@***.***> wrote:
Add a couple additional environment variables for ease of development and Flagger configurability.
You can view, comment on, or merge this pull request online at:
#123
Commit Summary
Use RUN_ONCE to only run the destalinate job once immediately
Add FLAGGER_DISABLED environment variable
File Changes
M README.md (4)
M scheduler.py (9)
Patch Links:
https://github.com/randsleadershipslack/destalinator/pull/123.patch
https://github.com/randsleadershipslack/destalinator/pull/123.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No bug, just didn't plan on using it. |
TheConnMan
force-pushed
the
additional-env-vars
branch
from
August 17, 2017 22:22
113f30d
to
84659ce
Compare
Okay, now that #122 was merged... can we use the central Config object for these? ;) |
Definitely for |
TheConnMan
force-pushed
the
additional-env-vars
branch
from
August 31, 2017 02:03
84659ce
to
d572c8c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple additional environment variables for ease of development and Flagger configurability.