Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional env vars #123

Merged

Conversation

TheConnMan
Copy link
Contributor

Add a couple additional environment variables for ease of development and Flagger configurability.

@kmarekspartz
Copy link
Contributor

kmarekspartz commented Aug 12, 2017 via email

@TheConnMan
Copy link
Contributor Author

No bug, just didn't plan on using it.

@kmarekspartz
Copy link
Contributor

Okay, now that #122 was merged... can we use the central Config object for these? ;)

@TheConnMan
Copy link
Contributor Author

Definitely for FLAGGER_DISABLED, I'm cool adding in RUN_ONCE for consistency, it's just a dev thing though, not as much a "config" thing.

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Coverage decreased (-0.4%) to 71.134% when pulling 0aa33ad on TheConnMan:additional-env-vars into d8533d3 on randsleadershipslack:master.

@kmarekspartz kmarekspartz merged commit 20cc549 into randsleadershipslack:master Aug 31, 2017
@TheConnMan TheConnMan deleted the additional-env-vars branch December 14, 2017 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants