Fixes related to validating worksheet name uniqueness #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a worksheet with an invalid name would still add it to the workbook, despite raising an exception.
This constraint would prevent you from creating a new worksheet with the name that it would have gotten by default.
|
Edit: Just pushed an update to the 2nd commit that actually includes the fix! Just thought I'd mention in case you looked at the patch from the original notification and didn't see it. |
|
please accept my sincerest apologies for the delay. Ive been away on a romote island with my kids for the last week. This looks good to me. Ill take deeper dive when i get back to civilization on the 7th and merge this in. best |
randym
added a commit
that referenced
this pull request
Jan 8, 2013
Fixes related to validating worksheet name uniqueness
|
Thanks! No worries about the delay - hope you enjoyed the vacation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0523e90 (Edward Anderson, 5 minutes ago)
Worksheet name uniqueness doesn't apply to itself
This constraint would prevent you from creating a new worksheet with the
name that it would have gotten by default.
cac5b8a (Edward Anderson, 33 minutes ago)
Don't add worksheets to the workbook when initialize fails
Creating a worksheet with an invalid name would still add it to the
workbook, despite raising an exception.