New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to validating worksheet name uniqueness #155

Merged
merged 2 commits into from Jan 8, 2013

Conversation

Projects
None yet
2 participants
@nilbus
Contributor

nilbus commented Jan 3, 2013

0523e90 (Edward Anderson, 5 minutes ago)
Worksheet name uniqueness doesn't apply to itself

This constraint would prevent you from creating a new worksheet with the
name that it would have gotten by default.

cac5b8a (Edward Anderson, 33 minutes ago)
Don't add worksheets to the workbook when initialize fails

Creating a worksheet with an invalid name would still add it to the
workbook, despite raising an exception.

nilbus added some commits Jan 2, 2013

Don't add worksheets to the workbook when initialize fails
Creating a worksheet with an invalid name would still add it to the
workbook, despite raising an exception.
Worksheet name uniqueness doesn't apply to itself
This constraint would prevent you from creating a new worksheet
with the name that it would have gotten by default.
@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Jan 3, 2013

Contributor

Edit: Just pushed an update to the 2nd commit that actually includes the fix! Just thought I'd mention in case you looked at the patch from the original notification and didn't see it.

Contributor

nilbus commented Jan 3, 2013

Edit: Just pushed an update to the 2nd commit that actually includes the fix! Just thought I'd mention in case you looked at the patch from the original notification and didn't see it.

@randym

This comment has been minimized.

Show comment
Hide comment
@randym

randym Jan 4, 2013

Owner

please accept my sincerest apologies for the delay. Ive been away on a romote island with my kids for the last week. This looks good to me. Ill take deeper dive when i get back to civilization on the 7th and merge this in.

best
randym

Owner

randym commented Jan 4, 2013

please accept my sincerest apologies for the delay. Ive been away on a romote island with my kids for the last week. This looks good to me. Ill take deeper dive when i get back to civilization on the 7th and merge this in.

best
randym

randym added a commit that referenced this pull request Jan 8, 2013

Merge pull request #155 from nilbus/name-validation
Fixes related to validating worksheet name uniqueness

@randym randym merged commit dc29748 into randym:master Jan 8, 2013

1 check passed

default The Travis build passed
Details
@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Jan 8, 2013

Contributor

Thanks! No worries about the delay - hope you enjoyed the vacation!

Contributor

nilbus commented Jan 8, 2013

Thanks! No worries about the delay - hope you enjoyed the vacation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment