Pull dominantColors per https://github.com/randytarampi/lwip/pull/28
#30
Conversation
Specifically 3c22027, 55fdda7...e6c898e.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| let the_key = '0,0,0,0', | ||
| count = 0; | ||
| for (let key in colorCounter) { |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| } | ||
| } | ||
|
|
||
| let the_key = '0,0,0,0', |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const colorCounter = {}; | ||
| for (let i = 0; i < this.width(); i++) { | ||
| for (let j = 0; j < this.height(); j+= skips+1) { | ||
| const pixel = this.__lwip.getPixel(i,j), |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| const colorCounter = {}; | ||
| for (let i = 0; i < this.width(); i++) { | ||
| for (let j = 0; j < this.height(); j+= skips+1) { |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| } | ||
|
|
||
| const colorCounter = {}; | ||
| for (let i = 0; i < this.width(); i++) { |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| throw Error('Pass a positive integer argument for number of pixels to skip over each iteration'); | ||
| } | ||
|
|
||
| const colorCounter = {}; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| let dominantColor; | ||
| judges.dominantColor( | ||
| arguments, | ||
| skips => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| @@ -82,6 +83,47 @@ module.exports = class Image { | |||
| }; | |||
| } | |||
|
|
|||
| dominantColor () { | |||
| let dominantColor; | |||
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
Pull Request Test Coverage Report for Build 246
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 246
💛 - Coveralls |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #28 and EyalAr#255