Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): Add support for Twitter. #253

Merged
merged 8 commits into from
Jan 23, 2019
Merged

feat(service): Add support for Twitter. #253

merged 8 commits into from
Jan 23, 2019

Conversation

randytarampi
Copy link
Owner

Pretty straight forward change to close #79.

Meat

Sides

@randytarampi
chore(service): Generalize an OAuthClient.
3d51c2a
@randytarampi
chore(service): OAuthClient -> OAuth2Client.
1f93c01
@randytarampi
feat(service): Add Twitter accounts per #250.
a2c4248 
The big idea here is that we'll pull tweets by the `GET statuses/user_timeline` endpoint.
@randytarampi
fix(jsx): ESLint.
26c4bb4 
Guess there was an upgrade to ESLint on the last `package-lock.json` refresh?

Prop types checking on component-as-functions now eh? More likely that they just fixed this I guess. 😂
@randytarampi
feat(service): First pass at adding Twitter.
3f0e2ee 
Committing now to capture the state of `Photo` and `Gallery` content. Gonna make everything a `Post` since we can't embed any `media_url`s (apparently).

Per #79.
@randytarampi
feat(service): All tweets are just Posts.
32f6f2d 
Cleanup #79.
@randytarampi
feat(service): Tweets in_reply_to_screen_name aren't worthy of visi…
f92f2f1 
…bility.

Just hide my public conversations with people.
@randytarampi
feat(service): Polish off coverage for 3d51c2a...f92f2f1.
3a69a7e
@randytarampi randytarampi added the enhancement New feature or request label Jan 23, 2019
@randytarampi randytarampi added this to the Add more `Post`s milestone Jan 23, 2019
@randytarampi randytarampi self-assigned this Jan 23, 2019
@ghost ghost added the in progress Issues with solutions in progress label Jan 23, 2019
@randytarampi randytarampi merged commit 49d888a into master Jan 23, 2019
@ghost ghost removed the in progress Issues with solutions in progress label Jan 23, 2019
@randytarampi randytarampi deleted the service-twitter branch January 23, 2019 08:03
@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited

Pull Request Test Coverage Report for Build 1943

  • 151 of 153 (98.69%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.06%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/service/src/lib/sources/twitter/source.js 78 80 97.5%
Totals Coverage Status
Change from base Build 1941: 0.04%
Covered Lines: 3288
Relevant Lines: 3345
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@randytarampi randytarampi

Labels
enhancement New feature or request
Projects
None yet
Milestone
Add more `Post`s
Development

Successfully merging this pull request may close these issues.

Add support for Twitter
2 participants
@randytarampi @coveralls