Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade isomorphic-fetch from 2.2.1 to 3.0.0 #749

Closed
wants to merge 1 commit into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • packages/letter/package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 591/1000
Why? Recently disclosed, Has a fix available, CVSS 5.9
Denial of Service
SNYK-JS-NODEFETCH-674311
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: isomorphic-fetch The new version differs by 12 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
馃 View latest project report

馃洜 Adjust project settings

馃摎 Read more about Snyk's upgrade and patch logic

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

聽聽聽聽聽fix: packages/letter/package.json to reduce vulnerabilities

Powered by Pull Assistant. Last update a7ba97b ... a7ba97b. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files         363      363           
  Lines        3743     3743           
  Branches      309      309           
=======================================
  Hits         3528     3528           
  Misses        175      175           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 804ca3f...a7ba97b. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Sep 23, 2020

Code Climate has analyzed commit a7ba97b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.6%.

View more on Code Climate.

@randytarampi
Copy link
Owner

Closed in 40b9654

@randytarampi randytarampi deleted the snyk-fix-737dac6989e592520ed7f458a1bf0863 branch November 29, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants