chore(greenkeeper): Update dependencies and enable Greenkeeper #65

greenkeeper · 2019-07-06T07:11:09Z

Let’s get started with automated dependency management for slamscan 💪

🔒 Greenkeeper has found a package-lock.json file in this repository. Greenkeeper supports lockfile updates for public packages. If you use private packages in your repository, please use greenkeeper-lockfile to make sure these can get updated as well.

This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after you merge this pull request.

Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request.

💥 Tests on this branch are failing. Here’s how to proceed.

To solve the issue, first find out which of the dependency’s updates is causing the problem. Then fix your code to accomodate the changes in the updated dependency. next-update is a really handy tool to help you with this.

Then push your changes to this branch and merge it.

🏗 How to configure Travis CI

Greenkeeper has added a rule to your .travis.yml that whitelists Greenkeeper branches, which are created when your dependencies are updated. Travis CI will run your tests on these branches automatically to see if they still pass.

No additional setup is required 😊

🙈 How to ignore certain dependencies

You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can change the dependency’s version string in the package.json file back to whatever you prefer.

To make sure Greenkeeper doesn’t nag you again on the next update, add a greenkeeper.ignore field to your package.json, containing a list of dependencies you don’t want to update.

// package.json
{
  …
  "greenkeeper": {
    "ignore": [
      "package-names",
      "you-want-me-to-ignore"
    ]
  }
}

👩‍💻 How to update this pull request

  # Change into your repository’s directory
  git fetch --all
  git checkout greenkeeper/initial
  npm install-test
  # Adapt your code until everything works again
  git commit -m 'chore: adapt code to updated dependencies'
  git push https://github.com/randytarampi/slamscan.git greenkeeper/initial

✨ How do dependency updates work with Greenkeeper?

After you merge this pull request, Greenkeeper will create a new branch whenever a dependency is updated, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

The above example shows an in-range update. 1.7.0 is included in the old ^1.6.0 range, because of the caret ^ character .
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.

However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.

This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

In this example, the new version 4.0.0 is not included in the old ^3.0.0 range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.

This means that you no longer need to check for new versions manually – Greenkeeper will keep you up to date automatically.

These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away

To get a better idea of which ranges apply to which releases, check out the extremely useful semver calculator provided by npm.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Good luck with your project and see you soon ✨

Your Greenkeeper bot 🌴

greenkeeper · 2019-07-13T20:38:07Z

Hey there 👋,

we noticed that this PR isn’t merged yet. Just to let you know: if you don't merge this PR, Greenkeeper will not be enabled on this repo, and you won't receive updates for your dependencies.

If you don't want to enable Greenkeeper here, just close or ignore this PR, we won't nag you again. ✌️

Have a great day! 🌴

pull-assistant · 2020-01-07T06:55:08Z

Best reviewed: commit by commit

Optimal code review plan

chore(greenkeeper): Update dependencies.

chore(package): update lockfile package-lock.json

feat(package): Blindly upgrade our dependencies for the new year and s...

Powered by Pull Assistant. Last update 2d19b8a ... 9c9cc82. Read the comment docs.

hound · 2020-01-07T07:07:59Z

src/lib/clamscan.js

-    }
+export const scanFile = file => getClamscan()
+    .then(scanner => new Promise((resolve, reject) => {
+        scanner.is_infected(file, (error, file, isInfected) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-01-07T07:08:00Z

src/lib/clamscan.js

-        return reject(error);
-    }
+export const scanFile = file => getClamscan()
+    .then(scanner => new Promise((resolve, reject) => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

hound · 2020-01-07T07:08:00Z

src/lib/clamscan.js

-    if (error) {
-        return reject(error);
-    }
+export const scanFile = file => getClamscan()


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'export' is only available in ES6 (use 'esversion: 6').

hound · 2020-01-07T07:08:00Z

src/lib/clamscan.js

@@ -2,7 +2,7 @@ import Clamscan from "clamscan";

 export const CLAMSCAN_DB_FILES = ["main.cvd", "daily.cvd", "bytecode.cvd"];

-export const getClamscan = () => new Clamscan({
+export const getClamscan = () => new Clamscan().init({


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'export' is only available in ES6 (use 'esversion: 6').

…support node@10. BREAKING CHANGE: Really, this is more about dropping support for node@8, but AWS is disallowing creation of node@8 lambdas today anyways, per https://docs.aws.amazon.com/lambda/latest/dg/runtime-support-policy.html. Also, we'll also need to have real virus definitions on hand as the rewrite of `clamscan` dropped the testing mode. Which is unfortunate.

randytarampi · 2020-01-07T07:35:36Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

greenkeeper bot added 2 commits July 6, 2019 07:07

chore(greenkeeper): Update dependencies.

2d19b8a

chore(package): update lockfile package-lock.json

054edac

greenkeeper bot added the greenkeeper label Jul 6, 2019

randytarampi added this to In Progress in me via automation Jul 6, 2019

randytarampi force-pushed the greenkeeper/initial branch 25 times, most recently from 8a6d126 to 794e5d7 Compare January 7, 2020 06:04

randytarampi force-pushed the greenkeeper/initial branch 6 times, most recently from fff2fb8 to 291ccf8 Compare January 7, 2020 06:55

randytarampi force-pushed the greenkeeper/initial branch from 291ccf8 to b6ba2ec Compare January 7, 2020 07:07

hound bot reviewed Jan 7, 2020

View reviewed changes

randytarampi force-pushed the greenkeeper/initial branch from b6ba2ec to 9c9cc82 Compare January 7, 2020 07:12

randytarampi merged commit a63ca68 into master Jan 7, 2020

me automation moved this from In Progress to Done Jan 7, 2020

greenkeeper bot deleted the greenkeeper/initial branch January 7, 2020 07:30

randytarampi added the released label Jan 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(greenkeeper): Update dependencies and enable Greenkeeper #65

chore(greenkeeper): Update dependencies and enable Greenkeeper #65

greenkeeper bot commented Jul 6, 2019

greenkeeper bot commented Jul 13, 2019

pull-assistant bot commented Jan 7, 2020 •

edited

hound bot Jan 7, 2020

hound bot Jan 7, 2020

hound bot Jan 7, 2020

hound bot Jan 7, 2020

randytarampi commented Jan 7, 2020

chore(greenkeeper): Update dependencies and enable Greenkeeper #65

chore(greenkeeper): Update dependencies and enable Greenkeeper #65

Conversation

greenkeeper bot commented Jul 6, 2019

greenkeeper bot commented Jul 13, 2019

pull-assistant bot commented Jan 7, 2020 • edited

hound bot Jan 7, 2020

Choose a reason for hiding this comment

hound bot Jan 7, 2020

Choose a reason for hiding this comment

hound bot Jan 7, 2020

Choose a reason for hiding this comment

hound bot Jan 7, 2020

Choose a reason for hiding this comment

randytarampi commented Jan 7, 2020

pull-assistant bot commented Jan 7, 2020 •

edited