Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Add remaining keyword arguments #8

Closed
7 tasks done
randyzwitch opened this issue Dec 16, 2018 · 1 comment
Closed
7 tasks done

Add remaining keyword arguments #8

randyzwitch opened this issue Dec 16, 2018 · 1 comment

Comments

@randyzwitch
Copy link
Owner

randyzwitch commented Dec 16, 2018 •
edited

Migrate existing code to use query parameter for building urls, then add additional keyword arguments shown for Swagger interface

  • CalculatedMetrics
  • Collections (GetReportSuites...simplify by removing rsid vs rsids?)
  • DateRanges
  • Dimensions
  • Metrics
  • Users
  • Segments
randyzwitch added a commit that referenced this issue Dec 29, 2018
@randyzwitch
Switch to query parameter in httr
4cb3252 
Work towards #8, only switched over GetMetrics and GetDimensions as they currently have query parameters for rsid
@randyzwitch randyzwitch mentioned this issue Dec 29, 2018
Closed
7 tasks
randyzwitch added a commit that referenced this issue Dec 29, 2018
@randyzwitch
Add kw to GetCalculatedMetrics
53bdb1e 
Work towards #8. Instead of using Adobe defaults, chose 100 for limit to avoid needing to page for up to 100 values. Feels like paging for a function like this unnecessary in all but the largest implementations
@randyzwitch
Copy link
Owner Author

Didn't remove rsid in favor of rsids...not sure there is a difference, but since Adobe provides it, will provide functionality even if duplicated

@randyzwitch randyzwitch mentioned this issue Dec 30, 2018
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@randyzwitch