Too many calls to 'rate limit status' #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wojcik cursorize
|
LGTM, but I haven't tested it locally. Happy to merge if you're asserting it works, otherwise it might be a few days before I can check this out |
|
I just double-checked on a separate machine and it checks out. I think it's good to merge, changes are pretty minimal in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Randy,
I noticed I introduced a bug on the my last PR. I noticed while using the Twitter package that it was making an excessive number of calls to the rate limit status endpoint. This logic of course was to prevent to many calls to the API, but the 'reconnect loop' would issue three calls to the rate limit endpoint per ANY call, which was way too much and causing errors.
To fix this, I created an API_INFO global to hold the status of all the endpoints and to subtract from that endpoint count object each time a call is made to a particular endpoint. That way, the program counts the remaining allocations for each endpoint without needing to call the rate limit endpoint. When it runs out of calls, it resets the count by calling the rate limit status endpoint. All tests pass.