Fix map center and zoom map update #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackary
reviewed
Dec 21, 2023
blackary
approved these changes
Dec 21, 2023
|
Since it's not clear how to automate a test, let's go with it for now and write a test later when it becomes more obvious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154.
@blackary the solution you proposed in #154 to change the widget key works, but it triggers a widget reloading (map quickly disappearing and appearing again). This can be avoided by using setView instead of manually setting the zoom and the center separately (see leafleat issue 170.
I couldn't add tests since (to the best of my knowledge) playwright doesn't allow to interact with the map (change center and zoom). But you can test it on your side with the same sample code as in #154 and it works fine.
Tests were passing on my side.