Dynamically load javascript and css links #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansthen
changed the title
Horribly mutilated code. Still needs to be cleaned up.
hansthen
force-pushed
the
issue_180_generate_js_and_css_links_dynamically
branch
from
570511c
to
cf796ea
Compare
There is also code included to ensure we can run without any js links, which is a should not happen scenario. Need to test this later and see if it can be removed again. Also, Dual Map tests do not work, but this is because the dual map feature is also broken.
|
Closes issue #180 |
blackary
approved these changes
Apr 25, 2024
That's nice to hear. I am impressed (and a little intimidated) by how you managed to update |
hansthen
added a commit
to hansthen/streamlit-folium
that referenced
this pull request
May 4, 2024
* First version that works Horribly mutilated code. Still needs to be cleaned up. * WIP tests fixed There is also code included to ensure we can run without any js links, which is a should not happen scenario. Need to test this later and see if it can be removed again. Also, Dual Map tests do not work, but this is because the dual map feature is also broken. * Fix DualMap * Black * Dummy change to trigger build rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically load javascript and css links.
This change will inspect the
Foliummap and then add included js and css links to the page. I managed to fix the tests.Javascript and typescript are not my main languages. Suggestions on how to improve this are welcome.