Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validate-appdata test #101

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

iFoundSilentHouse
Copy link
Contributor

closes #100

Copy link
Contributor

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should instead put the list inside a paragraph, so that formatting doesn't look weird when rendered

@iFoundSilentHouse
Copy link
Contributor Author

Like this?

diff --git a/data/com.ranfdev.Geopard.metainfo.xml.in.in b/data/com.ranfdev.Geopard.metainfo.xml.in.in
index d2ffa1f..e27ffb2 100644
--- a/data/com.ranfdev.Geopard.metainfo.xml.in.in
+++ b/data/com.ranfdev.Geopard.metainfo.xml.in.in
@@ -88,10 +88,12 @@
     </release>
     <release version="1.1.0" date="2022-05-19">
       <description>
-        <p>Improved design, with completely new pages for downloads, input requests, external links, errors</p>
-        <p>Added more spacing between links to make them easier to click on small screens</p>
-        <p>Added zoom functionality, via shortcuts or directly from the popover menu</p>
-        <p>Streaming button (alpha) for some audio/video file types</p>
+        <p>
+          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
+          <li>Added more spacing between links to make them easier to click on small screens</li>
+          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
+          <li>Streaming button (alpha) for some audio/video file types</li>
+        </p>
       </description>
     </release>
     <release version="1.0.1" date="2022-05-07">
'''

@iFoundSilentHouse
Copy link
Contributor Author

Test failed that way with <p> is too short

@iFoundSilentHouse
Copy link
Contributor Author

diff --git a/data/com.ranfdev.Geopard.metainfo.xml.in.in b/data/com.ranfdev.Geopard.metainfo.xml.in.in
index f35c019..8f58603 100644
--- a/data/com.ranfdev.Geopard.metainfo.xml.in.in
+++ b/data/com.ranfdev.Geopard.metainfo.xml.in.in
@@ -88,12 +88,10 @@
     </release>
     <release version="1.1.0" date="2022-05-19">
       <description>
-        <ul>
-          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
-          <li>Added more spacing between links to make them easier to click on small screens</li>
-          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
-          <li>Streaming button (alpha) for some audio/video file types</li>
-        </ul>
+        <p><li>Improved design, with completely new pages for downloads, input requests, external links, errors</li></p>
+        <p><li>Added more spacing between links to make them easier to click on small screens</li></p>
+        <p><li>Added zoom functionality, via shortcuts or directly from the popover menu</li></p>
+        <p><li>Streaming button (alpha) for some audio/video file types</li></p>
       </description>
     </release>
     <release version="1.0.1" date="2022-05-07">

Failed with same error

@tfuxu
Copy link
Contributor

tfuxu commented Apr 6, 2024

No, you should put it like that:

<p>
    <ul>
        <li>Item 1</li>
        <li>Item 2</li>
        <li>Item 3</li>
    </ul>
</p>

@iFoundSilentHouse
Copy link
Contributor Author

-        <ul>
-          <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
-          <li>Added more spacing between links to make them easier to click on small screens</li>
-          <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
-          <li>Streaming button (alpha) for some audio/video file types</li>
-        </ul>
+        <p>
+          <ul>
+            <li>Improved design, with completely new pages for downloads, input requests, external links, errors</li>
+            <li>Added more spacing between links to make them easier to click on small screens</li>
+            <li>Added zoom functionality, via shortcuts or directly from the popover menu</li>
+            <li>Streaming button (alpha) for some audio/video file types</li>
+          </ul>
+        </p>

Failed with same error

@tfuxu
Copy link
Contributor

tfuxu commented Apr 7, 2024

I don't know how the packaging works in void, but can you use validate-relax in appstream-util?

Try patching data/meson.build line 50 by replacing validate with validate-relax.

@iFoundSilentHouse
Copy link
Contributor Author

iFoundSilentHouse commented Apr 7, 2024

It worked! Thank you. Should I use it as main patch for void package?

@iFoundSilentHouse
Copy link
Contributor Author

iFoundSilentHouse commented Apr 7, 2024

Also, I can add this as a commit in this pr. Is it needed?

@ranfdev ranfdev merged commit f17a9e6 into ranfdev:master Apr 9, 2024
@ranfdev
Copy link
Owner

ranfdev commented Apr 9, 2024

thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate-appdata test failure
3 participants