New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility for recurrings earnings #40
Add the possibility for recurrings earnings #40
Conversation
database/migrations/2019_07_26_192824_make_recurring_earnings.php
Outdated
Show resolved
Hide resolved
database/migrations/2019_07_26_192824_make_recurring_earnings.php
Outdated
Show resolved
Hide resolved
@@ -9,7 +9,7 @@ | |||
<h2>{{ __('models.recurrings') }}</h2> | |||
</div> | |||
<div class="row__column row__column--compact row__column--middle"> | |||
<a href="/recurrings/create" class="button">{{ __('actions.create') }} {{ __('models.recurring') }}</a> | |||
<a href="/transactions/create" class="button">{{ __('actions.create') }} {{ __('models.recurring') }}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing it to transactions? We're making a recurring entry, which in turn makes a transaction. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I think for uniformity, use the TransactionWizard, so therefore use transactions/create. I don’t like the recurring/create-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And because that recurring/create-page can only create a recurring spending and no recurring earning
While I want to implement this feature, I think this PR has gone stale. Too many conflicts. I will open up another PR for this. |
No description provided.