-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with Kitty on OSX #1499
Comments
I tried upgrading ranger to 3.7.2. I'm getting the same issue (Feb 12, 2019) |
It's probably your If you changed it to |
Oh, or maybe it's because you need PIL/pillow. |
This issue was caused because I didn't have Perhaps it should be more verbose. |
That's weird. @mark-dawn did intend to implement a wrapper for ImageMagick to use it as an alternative dep to pillow in the future. But that hasn't happened yet so it's weird installing ImageMagick solved any problem. We do use ImageMagick to automatically rotate images. Maybe all the images you've tried had to be rotated? Could you download some random |
I had the same problem as user @EvanCarroll. Installing
to
Is there a different way to have ranger default to the brew installation of python? |
Normally scripts would use To anyone who wants an easier way to test if they installed pillow/any module for the interpreter that's actually running ranger, start ranger and then |
@EvanCarroll, can you confirm whether unrotated images did/did not preview without imagemagick? And could you check whether you actually installed pillow for the right python? Easily checked by running @ebv-gh, that's actually a sorta common mistake people make, installing deps for the wrong python. Normally the shebang'd be |
Thanks for this .. I've just gone through this nightmare myself and this is what fixed it for me. |
Works for me too. There is a way to add this change on the config instead edit |
I also had this problem. I solved it by installing |
Thanks! It just solves the problem. |
Looks like Homebrew packagers picked up on this issue and it got fixed on their side 🎉 |
This comment was marked as spam.
This comment was marked as spam.
I think this is still broken. I'm on an M2 using System: [ steven ] [~] > uname -a []
Darwin Swordfish 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun 8 22:21:34 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8112 arm64
[ steven ] [~] > zsh --version []
zsh 5.9 (x86_64-apple-darwin22.0)
[ steven ] [~] > kitty --version []
kitty 0.27.1 created by Kovid Goyal
[ steven ] [~] > ranger --version []
ranger version: ranger 1.9.3
Python version: 3.11.4 (main, Jun 20 2023, 17:23:00) [Clang 14.0.3 (clang-1403.0.22.14.1)]
Locale: en_US.UTF-8
[ steven ] [~] > conda --version []
conda 23.5.0
[ steven ] [~] > python --version []
Python 3.11.4
[ steven ] [~] > python -c "import PIL" []
[ steven ] [~] > # success
[ steven ] [~] > /usr/bin/python3 -c "import PIL" []
[ steven ] [~] > # success
Looking back at homebrew we have depends_on "python@3.11"
def python
Formula["python@3.11"].opt_libexec/"bin/python"
end But the M2's system python is [ steven ] [~] > /usr/bin/python3 --version []
Python 3.9.6 Even upgrading my conda version doesn't work (was on 3.10 before) [ steven ] [~] > python --version []
Python 3.11.4 I tried installing Message Log:
ranger 1.9.3
Python version 3.11.4 (...) [Clang 14.0.3 (...)]
...
ERRO Notification: The error `No module named 'PIL'` was created... I thought maybe the issue was I'm kinda at a loss here as to what else it could be. Any ideas? |
@stevenwalton, I suspect Homebrew has installed Python 3.11.4 too, to satisfy the dependency so it's not actually using the Python provided by Conda. Run |
This gives me So of course So I am still quite certain that this is a bug, not a feature nor user error. |
I agree, but it's a bug in the Homebrew packaging, not Ranger. |
Issue taken to Homebrew. Worth also noting that I do not see I do also believe it is in the ranger team's interest to resolve package manager issues when the package manager is sufficiently popular and is an expected method of installation for users. Though I understand this is not an officially endorsed method I think it would benefit users. |
The problem is one of workload. There's a lot of package managers out there. We have to rely on volunteer maintainers for them. I'm not sure this is on the Homebrew maintainers either though. Pillow is not really a Ranger dependency, it's only needed for the Kitty and Ueberzug preview methods. Pillow's mentioned in the man page but it is conspicuously missing from the README, thanks for pointing this out. |
Addresses a [comment from ranger#1499][1] pointing out the lack of mention of the Pillow dependency in the README. [1]: ranger#1499 (comment)
I'm using Kitty on osx and (from the kitty docs)
does in fact work, but having
Inside of
rc.conf
does not make ranger render the images. I'm using ranger 1.9.2 and Kitty 0.13.3 (both installed with brew)The text was updated successfully, but these errors were encountered: