Add font viewing section and option to rifle #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds fontforge as a default option, but would benefit from adding other common options for previewing fonts.
toonn
requested changes
Jan 15, 2019
There was a problem hiding this comment.
I'm actually ok with merging this with the convert because fixing the code is probably a lot of work and other convert calls might be similarly unnecessary after the fix.
So let's just open an issue on that and point to all the uses of convert in scope.sh that would be redundant.
One small thing though, would adding some spaces to the strings create some margin at the left side of the previews? The characters starting at the very edge isn't nice imo.
- Make font-name bigger than the body - Vertically center the body so that the newline at the bottom doesn’t stand out as much
One un-double-quoted variable substitution. Directly use the commands escape code rather than relying on "$?", this also drops the need to rely on `>` which is for string comparison specifically.
Since we’re now checking whether fontimage runs successfully rather than if it throws an error, the conditions needs to be inverted.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
RUNTIME ENVIRONMENT
CHECKLIST
CONTRIBUTINGdocument has been read [REQUIRED]DESCRIPTION
Adds fontforge as a default option for previewing fonts, but would benefit from adding other common options for previewing fonts.
MOTIVATION AND CONTEXT
There wasn't any option to preview fonts before.