Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename_append: Use rename if point is on a directory #1469

Merged
merged 2 commits into from Feb 13, 2019

Conversation

zaeph
Copy link
Contributor

@zaeph zaeph commented Feb 10, 2019

ISSUE TYPE

  • Bug fix

RUNTIME ENVIRONMENT

  • Operating system and version: Arch
  • Terminal emulator and version: Terminator
  • Python version: 3.7.2
  • Ranger version/commit: 1.9.2
  • Locale: en_GB

CHECKLIST

  • The CONTRIBUTING document has been read [REQUIRED]
  • All changes follow the code style [REQUIRED]
  • All new and existing tests pass [REQUIRED]
  • Changes require config files to be updated
    • Config files have been updated
  • Changes require documentation to be updated
    • Documentation has been updated
  • Changes require tests to be updated
    • Tests have been updated

DESCRIPTION

When the directory at point has full-stops in it, rename_append would
put the point at the last period in the dir-name, as it would with a
file. This commit addresses this issue.

When the directory at point has full-stops in it, rename_append would
put the point at the last period in the dir-name, as it would with a
file.
Copy link
Member

@vifon vifon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@vifon vifon merged commit 29e51e1 into ranger:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants