Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

fix(explorer): debounce dirty notifications and ignore vendorChunk #264

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix(explorer): debounce dirty notifications and ignore vendorChunk #264

merged 1 commit into from Apr 8, 2020

Conversation

mgechev
Copy link
Contributor

@mgechev mgechev commented Apr 8, 2020

  1. On scroll event we can very aggressively request updates. Although we have throttling logic, it still can be quite a heavy operation in the front end. Here we introduce 50ms throttling.
  2. Do not produce vendorChunk in development (and production) modes.

1. On scroll event we can very aggressively request updates. Although we have throttling logic, it still can be quite a heavy operation in the front end. Here we introduce 50ms throttling.
2. Do not produce `vendorChunk` in development (and production) modes.
Copy link
Contributor

@AleksanderBodurri AleksanderBodurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgechev mgechev merged commit 96fc4f6 into rangle:master Apr 8, 2020
@mgechev mgechev deleted the limited-retry branch April 8, 2020 18:35
AleksanderBodurri pushed a commit to AleksanderBodurri/angular-devtools that referenced this pull request Sep 16, 2021
…angle#264)

1. On scroll event we can very aggressively request updates. Although we have throttling logic, it still can be quite a heavy operation in the front end. Here we introduce 50ms throttling.
2. Do not produce `vendorChunk` in development (and production) modes.
AleksanderBodurri pushed a commit to AleksanderBodurri/angular-devtools that referenced this pull request Sep 27, 2021
…angle#264)

1. On scroll event we can very aggressively request updates. Although we have throttling logic, it still can be quite a heavy operation in the front end. Here we introduce 50ms throttling.
2. Do not produce `vendorChunk` in development (and production) modes.
AleksanderBodurri pushed a commit to AleksanderBodurri/angular-devtools that referenced this pull request Oct 27, 2021
…angle#264)

1. On scroll event we can very aggressively request updates. Although we have throttling logic, it still can be quite a heavy operation in the front end. Here we introduce 50ms throttling.
2. Do not produce `vendorChunk` in development (and production) modes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants