This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
fix(backend): skip node if there is no associated TViewData #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure may just be the flaky CI as described in another PR. |
markwhitfeld
force-pushed
the
fix/handle-null-in-tviewdata
branch
from
de925f3
to
a6e9b32
Compare
|
Ok, build passes now. So it was the flaky CI. |
mgechev
reviewed
May 23, 2021
mgechev
approved these changes
May 23, 2021
The code was assuming that the TViewData item at the same index as the node in LView would contain a data entry. This value can be `null` (which is the case in our app), which causes a catastrophic failure in the dev tool. By checking for null, the node is skipped because it cannot determine the associated component or directive and the dev tool does not die. fixes issue rangle#801
markwhitfeld
force-pushed
the
fix/handle-null-in-tviewdata
branch
from
a6e9b32
to
57b2384
Compare
|
Rebased on |
AleksanderBodurri
pushed a commit
to AleksanderBodurri/angular-devtools
that referenced
this pull request
Sep 16, 2021
* fix(backend): skip node if there is no associated TViewData The code was assuming that the TViewData item at the same index as the node in LView would contain a data entry. This value can be `null` (which is the case in our app), which causes a catastrophic failure in the dev tool. By checking for null, the node is skipped because it cannot determine the associated component or directive and the dev tool does not die. fixes issue rangle#801 * chore: style tweak - add early return to avoid nesting
AleksanderBodurri
pushed a commit
to AleksanderBodurri/angular-devtools
that referenced
this pull request
Sep 27, 2021
) * fix(backend): skip node if there is no associated TViewData The code was assuming that the TViewData item at the same index as the node in LView would contain a data entry. This value can be `null` (which is the case in our app), which causes a catastrophic failure in the dev tool. By checking for null, the node is skipped because it cannot determine the associated component or directive and the dev tool does not die. fixes issue rangle#801 * chore: style tweak - add early return to avoid nesting
AleksanderBodurri
pushed a commit
to AleksanderBodurri/angular-devtools
that referenced
this pull request
Oct 27, 2021
* fix(backend): skip node if there is no associated TViewData The code was assuming that the TViewData item at the same index as the node in LView would contain a data entry. This value can be `null` (which is the case in our app), which causes a catastrophic failure in the dev tool. By checking for null, the node is skipped because it cannot determine the associated component or directive and the dev tool does not die. fixes issue rangle#801 * chore: style tweak - add early return to avoid nesting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was assuming that the TViewData item at the same index as the node
in LView would contain a data entry. This value can be
null(which is thecase in our app), which causes a catastrophic failure in the dev tool. By
checking for null, the node is skipped because it cannot determine the
associated component or directive and the dev tool does not die.
fixes issue #801