Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for example projects #94

Merged
merged 2 commits into from Nov 26, 2019
Merged

Update UI for example projects #94

merged 2 commits into from Nov 26, 2019

Conversation

yallen011
Copy link
Contributor

@yallen011 yallen011 commented Nov 25, 2019

Updated ui for the example projects.
Closes #95

Copy link
Contributor

@feeloor feeloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just minor comments.

src/styles.css Outdated



;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the spacing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/styles.css Outdated
background: #f1e0ff;
}
} */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we want to remove this? If we are commenting it out can we just remove it completely instead?

* refactored header into a shared component for reusability
Copy link
Member

@sumitarora sumitarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor changes mentioned already. LGTM

@feeloor
Copy link
Contributor

feeloor commented Nov 26, 2019

LGTM 👍

@sumitarora sumitarora merged commit e05c051 into master Nov 26, 2019
@sumitarora sumitarora deleted the forms-demo-ui-update branch January 6, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI in Augury Examples Project
3 participants