Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Augury impact is excessive when using the Performance Profiler plugin. #36

Open
santiago-elustondo opened this issue Jan 3, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@santiago-elustondo
Copy link
Contributor

Problem:
When looking at the timeline, it's clear that Augury's impact when collecting data is too large.
Augury's CPU usage is many times that of the example app. When using Augury to profile an app with performance issues, it makes the application freeze.

The core is quite lean, and the UI uses a timed repaint strategy to avoid repainting every time it gets new data.

Possible bottleneck:
performance-profiler-plugin does some pretty heavy tree traversals every time it gets new data (which happens extremely often). These could probably be optimized or avoided.

Thoughts?

@santiago-elustondo
Copy link
Contributor Author

This plugin looks like it needs a cleanup anyway, I could do a PR?

@stevenkampen
Copy link
Contributor

🙇 I've been meaning to dive further into this also. Let me know what you find :) I imagine there's some quite low hanging fruit.

@santiago-elustondo santiago-elustondo added the bug Something isn't working label Jan 9, 2019
@KamiShikkaku
Copy link

Any update on this? Is this project dead?

@santiago-elustondo
Copy link
Contributor Author

Been meaning to jump on it.. Will do this weekend.

@andrewthauer
Copy link
Contributor

andrewthauer commented Apr 2, 2019

We're doing some refactoring that should address existing performance concerns. Stay tuned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants