This repository has been archived by the owner on May 25, 2021. It is now read-only.
Escape double quotes in node description so sanitizeHtml doesn't complain. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xorgy, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @clbond and @ericjim to be potential reviewers |
|
This PR addresses #520 |
|
🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding error message is printed for every node description render when running in development mode; polluting performance profiles and decimating performance.
This change may also have a small positive impact on performance in production, as sanitizeHtml will do one fewer parse loop per render, though in practice this is fairly cheap.