This repository has been archived by the owner on May 25, 2021. It is now read-only.
Significant performance improvement due to removal of deep clone operations inside of JSON diff/patch #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clbond, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sumitarora, @ericjim and @vanessayuenn to be potential reviewers |
| @@ -0,0 +1,284 @@ | |||
| // This code contains work that is copyrighted to Joachim Wester (2013) | |||
There was a problem hiding this comment.
@clbond I am assuming that only the minimal code that is needed for Augury was forked into this file from the original repo?
There was a problem hiding this comment.
Yup, the bare minimum
|
@clbond LGTM PS. consider submitting a PR to the original repo if it makes sense |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have created a copy of a library that we depended upon, https://github.com/Starcounter-Jack/JSON-Patch, made a fork of it, made significant performance improvements to it, and then replaced our dependency on that library with our local fork.
The biggest performance improvement comes from the removal of the deep cloning operations that were happening inside the JSON patch library. These were completely unnecessary in the context of our use-case and introduced a significant performance bottleneck.