Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Show all the internal information in Providers accordion #662

Closed
igor-ka opened this issue Sep 14, 2016 · 4 comments
Closed

Show all the internal information in Providers accordion #662

igor-ka opened this issue Sep 14, 2016 · 4 comments
Assignees
Milestone

Comments

@igor-ka
Copy link

igor-ka commented Sep 14, 2016

Instead of handpicking which information to show for each of the built in providers as well as ignoring certain providers (like custom directives), show all of the information pertaining to the provider tokens.

For example:

  1. In the Kitchen Sink Demo app click Form Component section
  2. Select one of the input elements on the section of the component tree that appears
  3. Expand the Providers accordion and note the information shown there.
  4. Go to the console and input the following $a.injector.get($a.providerTokens[3]), this will show the information that corresponds to the NgControlName provider.
  5. Compare the information on the console with the information under the Providers accordion for the same provider.

We should shall ALL the information for each of the providers, i.e. should show all the same information as is shown on the console.

@igor-ka
Copy link
Author

igor-ka commented Sep 14, 2016

This issue was added as a result of investigation performed under investigation #648 and will support custom directives.

@xorgy
Copy link
Contributor

xorgy commented Sep 21, 2016

After taking a look at this information, and trying to serialize it, I've concluded: It would be a pretty big investment of time and effort to serialize most of this information in a generic way. It would be a much bigger investment of time and effort to display it well, as it means writing something similar to the state tree (but less tied to editing component state).

As a result of this I think I should prioritize work that I find more feasible. It is possible that a fresh set of eyes could solve this more easily.

@sumitarora
Copy link
Member

@xorgy I will take a look at this as well and then we can discuss how do we approach this and prioritize this one.

@igor-ka
Copy link
Author

igor-ka commented Sep 21, 2016

@sumitarora @xorgy thank you. we can revisit this in the next milestone and focus on higher value stuff for now.

@igor-ka igor-ka added in progress and removed ready labels Oct 13, 2016
@igor-ka igor-ka assigned clbond and unassigned xorgy Oct 13, 2016
@clbond clbond added ready and removed in progress labels Nov 7, 2016
@mobinni mobinni added in progress and removed ready labels Nov 16, 2016
@mobinni mobinni self-assigned this Nov 16, 2016
@mobinni mobinni added this to the 1.2.6 milestone Nov 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants