Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

drainQueue continues to send messages when port disconnected #832

Closed
rajinder-yadav opened this issue Nov 28, 2016 · 0 comments
Closed

drainQueue continues to send messages when port disconnected #832

rajinder-yadav opened this issue Nov 28, 2016 · 0 comments
Assignees
@rajinder-yadav
Milestone
1.2.6

Comments

@rajinder-yadav
Copy link
Contributor

rajinder-yadav commented Nov 28, 2016 •
edited by stevenkampen
Loading

An error is thrown only when a port is disconnected, ref:
https://developer.chrome.com/extensions/runtime#type-Port

  1. sending message should stop immediately on a JS error, this code can be optimised for run better.
  2. for loop splice can be eliminated, replaced by a single operation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rajinder-yadav rajinder-yadav

Labels
None yet
Projects
None yet
Milestone
1.2.6
Development

No branches or pull requests
2 participants
@rajinder-yadav @stevenkampen