New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic clear animation and cascading #82

Merged

bennett000 merged 1 commit into master from feat-clear-delay

Apr 10, 2018

bennett000 commented Apr 10, 2018 •

edited

closes #61

Game configuration now supports a configurable delay when blocks disappear
There is demo code to show how animations could be attached during this disappear delay
The cascading nature of the block drops is now reflected in the animation

** NOTE **

There are at least two known defects in this PR:

end game is not working, likely a regression from the week-end engine refactor
the blocks don't line up, I might have mucked up the rebase

Is the alignment a product of my resolution, or a merge error @smithad15 ?


          Basic clear animation and cascading

e283310

Author

bennett000 commented Apr 10, 2018

I can confirm the UI issue exists in master:

So I'm going to self with the animation changes

bennett000 merged commit d860ec6 into master

bennett000 deleted the feat-clear-delay branch

April 10, 2018 11:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment