Add datalayer renaming to gtm target #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…google-tag-manager.
…. Passing via settings object.
…-gtm-target Add datalayer renaming to gtm target
…-gtm-target Made dist folder available.
…naming-to-gtm-target Revert "Made dist folder available."
Closed
ttmarek
suggested changes
May 23, 2017
There was a problem hiding this comment.
This is awesome work, well done!
A couple of things though:
- Could you update google-tag-manager-node-env.test.js to use the new function signature?
- (optional) The target's docs will need to be updated before release. If you have the time and desire feel free to update the docs in this pull request. If not, that's cool. Up to you 🙂
|
|
||
| describe('GoogleTagManager(events)', () => { | ||
| describe('GoogleTagManager({...settings})(events)', () => { |
There was a problem hiding this comment.
I think options might be a better name for the signature, as it isn't required.
|
ttmarek
approved these changes
May 24, 2017
|
Fixes #97 This is excellent! And it'll be included as part of the next release (probably in one week's time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleTagManager new signature is like
GoogleTagManager({ ...settings })(eventArray)implemented dataLayerName setting. Default value is
'dataLayer'