Skip to content

Commit

Permalink
Support passing options as argument by Hash
Browse files Browse the repository at this point in the history
  • Loading branch information
kou committed Apr 18, 2016
1 parent a2b5396 commit c80b235
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
8 changes: 0 additions & 8 deletions ext/groonga/rb-grn-expression.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,6 @@ rb_grn_expression_define_variable (int argc, VALUE *argv, VALUE self)
return rb_variable;
}

/* TODO: Enable when Groonga 6.0.1 is released. */
/*
typedef struct
{
grn_ctx *context;
Expand Down Expand Up @@ -238,7 +236,6 @@ rb_grn_hash_from_ruby_hash_body (VALUE rb_key,

return ST_CONTINUE;
}
*/

/*
* _object_ を追加し、 _n_arguments_ 個の引数を取る _operation_ を追加する。
Expand Down Expand Up @@ -269,8 +266,6 @@ rb_grn_expression_append_object (int argc, VALUE *argv, VALUE self)
NULL, NULL,
NULL, NULL, NULL);

/* TODO: Enable when Groonga 6.0.1 is released. */
/*
if (RB_TYPE_P(rb_object, RUBY_T_HASH)) {
RbGrnHashFromRubyHashData data;
data.context = context;
Expand All @@ -288,13 +283,10 @@ rb_grn_expression_append_object (int argc, VALUE *argv, VALUE self)
grn_expr_append_obj(context, expression, (grn_obj *)(data.hash),
operation, n_arguments);
} else {
*/
object = RVAL2GRNOBJECT(rb_object, &context);
grn_expr_append_obj(context, expression, object,
operation, n_arguments);
/*
}
*/
rb_grn_context_check(context, self);
rb_ary_push(rb_iv_get(self, "@objects"), rb_object);

Expand Down
1 change: 0 additions & 1 deletion test/test-expression-builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,6 @@ def setup_data
end

def test_search
omit("TODO: Enable me when Groonga 6.0.1 is released.")
result = @tags.select do |record|
record.key.fuzzy_search("Toym", :with_transposition => true)
end
Expand Down

0 comments on commit c80b235

Please sign in to comment.